Removed several warnings when compiling with GCC 10.2 #8
Conversation
- stxxl::priority_queue uses std::memmove internally, which is only defined behavior for trivially copyable types. std::pair and std::tuple are not trivially copyable, even if all the stored types are trivially copyable, so storing them in a stxxl::priority_queue is technically undefined behavior. While this should still work as expected in all "sane" compilers, it is still against the standard and GCC 10.2 throws a warning. This commit fixes the only occurence of this warning in the "core" libraries stxxl and stxxl_tools. Note that there are many more occurences of this issues in the examples (e.g. in the skew3 algorithm) which remain unchanged by this commit. - stxxl::vector::const_vector_iterator had a user-defined copy-constructor but the automatically generated copy-assignment-operator. This throws a warning in GCC 10.2 (Typically, either both can be defaulted, or both have to be manually defined). The const_vector_iterator is a trivial type, so defaulting both operations works here and leads to a cleaner interface.
|
@bingmann We are currently using this fork of stxxl for the QLever project (@niklas88 suggested this switch quite some time ago). It seems to be newer than the "official" stxxl/stxxl repository, although both of them have slightly diverged. Could you please comment on the current status of stxxl? Is it still being officially maintained, and if yes, by whom? |
…ith really ancient compilers.
I also ask myself the question, is the project still alive ? I would be interested in maintaining it, but if not many people are interested I don't know if it's worth it. I thought I would do as I did on this project:
|
stxxl::priority_queue uses std::memmove internally, which is only defined behavior for trivially copyable types.
std::pair and std::tuple are not trivially copyable, even if all the stored types are trivially copyable, so storing
them in a stxxl::priority_queue is technically undefined behavior. While this should still work as expected in all "sane"
compilers, it is still against the standard and GCC 10.2 throws a warning. This commit fixes the only occurence of this warning
in the "core" libraries stxxl and stxxl_tools. Note that there are many more occurences of this issues in the examples
(e.g. in the skew3 algorithm) which remain unchanged by this commit.
stxxl::vector::const_vector_iterator had a user-defined copy-constructor but the automatically generated copy-assignment-operator.
This throws a warning in GCC 10.2 (Typically, either both can be defaulted, or both have to be manually defined). The const_vector_iterator
is a trivial type, so defaulting both operations works here and leads to a cleaner interface.