-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speaker button #22
Speaker button #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audio-output
and audio-input
has a some different.
audio-input
need sync state(enable/disable
) to remoteaudio-output
don't need sync state to remoteaudio-output
need set all useraudio-output
For audio-input
set `audio-input` -> `usewhip` -> if (enable/disable) sync to remote ----> server -> redis -> server -> `usewhep` -> set whep-player UI (enable/disable) audio
For audio-output
set `audio-output` -> state changed(For this project: jotai state) -> all local `whep-player` subscribe this state, all `whep-player` change `audio-output`
audio-output don't need use Server sync to remote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There button have enable/disable
status. Maybe We can use set muted
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/muted
The speaker button removes the button's disable/enable function, which is reasonable