Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaker button #22

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Speaker button #22

merged 11 commits into from
Nov 21, 2024

Conversation

xdzqyyds
Copy link
Contributor

The speaker button removes the button's disable/enable function, which is reasonable

Copy link
Member

@a-wing a-wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio-output and audio-inputhas a some different.

  • audio-input need sync state(enable/disable) to remote
  • audio-output don't need sync state to remote
  • audio-output need set all user audio-output

For audio-input

set `audio-input` -> `usewhip` -> if (enable/disable) sync to remote ----> server -> redis -> server -> `usewhep`  -> set whep-player UI (enable/disable) audio

For audio-output

set `audio-output` -> state changed(For this project: jotai state) -> all local `whep-player` subscribe this state, all `whep-player` change `audio-output`

audio-output don't need use Server sync to remote

webapp/components/device.tsx Outdated Show resolved Hide resolved
webapp/components/layout.tsx Outdated Show resolved Hide resolved
webapp/components/player/player.tsx Outdated Show resolved Hide resolved
webapp/components/player/whep-player.tsx Outdated Show resolved Hide resolved
webapp/components/use/whip.ts Outdated Show resolved Hide resolved
Copy link
Member

@a-wing a-wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There button have enable/disable status. Maybe We can use set muted

https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/muted

webapp/components/use/whxp.ts Outdated Show resolved Hide resolved
webapp/lib/api.ts Outdated Show resolved Hide resolved
webapp/store/atom.ts Outdated Show resolved Hide resolved
webapp/store/atom.ts Outdated Show resolved Hide resolved
webapp/components/player/player.tsx Show resolved Hide resolved
@a-wing a-wing merged commit 002fbad into binbat:main Nov 21, 2024
3 checks passed
@a-wing a-wing mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants