Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: return &'static str when returning String is unnecessary #261

Merged
merged 2 commits into from
Dec 21, 2024
Merged

refactor: return &'static str when returning String is unnecessary #261

merged 2 commits into from
Dec 21, 2024

Conversation

Integral-Tech
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
libs/api/src/path.rs 80.00% <100.00%> (ø)
libs/signal/src/lib.rs 86.95% <100.00%> (ø)
liveion/src/route/strategy.rs 100.00% <100.00%> (ø)
liveion/src/route/stream.rs 38.75% <100.00%> (ø)

@a-wing
Copy link
Member

a-wing commented Dec 21, 2024 •
edited
Loading

I'm very appreciation your contribution

@Integral-Tech
Copy link
Contributor Author

@a-wing Done :)

@a-wing a-wing added the mod::live777 Live777 server label Dec 21, 2024
@a-wing a-wing merged commit 5b87142 into binbat:main Dec 21, 2024
10 checks passed
@Integral-Tech Integral-Tech deleted the refactor-string branch December 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-wing a-wing a-wing left review comments

Assignees
No one assigned
Labels
mod::live777 Live777 server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integral-Tech @a-wing