Issue 235 #251
Closed
Issue 235 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use shadow-rs to get PKG_VERSION and COMMIT_HASH `core::concat` can only accept literals, so use `const_str::concat`
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚨 Try these New Features:
|
|
Welcome contributor this project CLA. please. https://github.com/binbat/woom/blob/main/.github/CLA.md#list-of-contributors You can read this example: #95 This projec has many binary, each binary should add hash version:
|
a-wing
added
enhancement
a-wing
approved these changes
Nov 22, 2024
| mod log; | ||
| mod utils; | ||
|
|
||
| #[derive(Parser)] | ||
| #[command(version)] | ||
| #[command(version = concat!("v",build::PKG_VERSION,"-",build::SHORT_COMMIT))] |
There was a problem hiding this comment.
We need display hash version, usually, concat string and v prefix is unnecessary
|
Temporarily closed, try to fix failure in test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
shadow-rsto get PKG_VERSION and COMMIT_HASHcore::concatcan only accept literals, so useconst_str::concatIt looks like: