Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:whipinto and whepfrom mode sdp file path failed at windows #247

Merged
merged 17 commits into from
Nov 5, 2024
Merged

fix:whipinto and whepfrom mode sdp file path failed at windows #247

merged 17 commits into from
Nov 5, 2024

Conversation

Marsyew
Copy link
Contributor

@Marsyew Marsyew commented Oct 28, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
livetwo/src/whep.rs 30.76% 6 Missing and 3 partials ⚠️
livetwo/src/whip.rs 44.44% 3 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
libs/cli/src/lib.rs 34.02% <100.00%> (+0.68%) ⬆️
tests/tests.rs 72.50% <ø> (ø)
livetwo/src/whip.rs 33.63% <44.44%> (-1.01%) ⬇️
livetwo/src/whep.rs 46.23% <30.76%> (-0.63%) ⬇️

... and 1 file with indirect coverage changes

a-wing
a-wing requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@a-wing a-wing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#230

Remove test_liveion_stream_connect and test_liveion_stream_ffmpeg unit test #[cfg(not(windows))]

libs/cli/src/lib.rs Outdated
@@ -133,7 +133,14 @@ pub fn get_codec_type(codec: &RTCRtpCodecCapability) -> RTPCodecType {

pub fn create_child(command: Option<String>) -> Result<Option<Mutex<Child>>> {
let child = if let Some(command) = command {
let command = if cfg!(windows) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfg! is macro!

livetwo/src/whep.rs Outdated Show resolved Hide resolved
livetwo/src/whep.rs Outdated Show resolved Hide resolved
@a-wing a-wing added bug Something isn't working mod::whipinto whipinto mod::whepfrom whepfrom labels Oct 28, 2024
@a-wing a-wing added this to the 0.7.0 milestone Nov 5, 2024
@a-wing
Copy link
Member

a-wing commented Nov 5, 2024

Fix #230

@a-wing a-wing merged commit db2184b into binbat:main Nov 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-wing a-wing a-wing requested changes

Assignees
No one assigned
Labels
bug Something isn't working mod::whepfrom whepfrom mod::whipinto whipinto
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Marsyew @a-wing