refactor:apply unit tests and error handling

binbat · Oct 29, 2024 · 6a53657 · 6a53657
1 parent fec3995
commit 6a53657
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/libs/cli/src/lib.rs b/libs/cli/src/lib.rs
@@ -133,12 +133,7 @@ pub fn get_codec_type(codec: &RTCRtpCodecCapability) -> RTPCodecType {
 
 pub fn create_child(command: Option<String>) -> Result<Option<Mutex<Child>>> {
     let child = if let Some(command) = command {
-        let command = if cfg!(windows) {
-            command.replace('\\', "/")
-        } else {
-            command
-        };
-
+        let command = command.replace('\\', "/");
         let mut args = shellwords::split(&command)?;
 
         Some(Mutex::new(

diff --git a/livetwo/src/whep.rs b/livetwo/src/whep.rs
@@ -63,7 +63,7 @@ pub async fn from(
         Some(Host::Domain(_)) | Some(Host::Ipv4(_)) => Ipv4Addr::UNSPECIFIED.to_string(),
         Some(Host::Ipv6(_)) => Ipv6Addr::UNSPECIFIED.to_string(),
         None => {
-            eprintln!("Invalid host for {}, using default.", input);
+            error!("Invalid host for {}, using default.", input);
             Ipv4Addr::UNSPECIFIED.to_string()
         }
     };
@@ -141,7 +141,7 @@ pub async fn from(
             .connection_information
             .and_then(|conn_info| conn_info.address)
             .map(|address| address.to_string())
-            .unwrap_or("127.0.0.1".to_string());
+            .unwrap_or(Ipv4Addr::LOCALHOST.to_string());
         for media in &mut session.media_descriptions {
             if media.media_name.media == "video" {
                 if let Some(port) = media_info.video_rtp_client {

diff --git a/tests/tests.rs b/tests/tests.rs
@@ -81,7 +81,6 @@ async fn test_liveion_stream_create() {
     assert_eq!(1, body.len());
 }
 
-#[cfg(not(windows))]
 #[tokio::test]
 async fn test_liveion_stream_connect() {
     let cfg = liveion::config::Config::default();
@@ -208,7 +207,6 @@ a=rtpmap:96 VP8/90000
     assert!(result.is_some());
 }
 
-#[cfg(not(windows))]
 #[tokio::test]
 async fn test_liveion_stream_ffmpeg() {
     let cfg = liveion::config::Config::default();