Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add python 3.12 to test workflows #280

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

angelofenoglio
Copy link
Contributor

What?

  • Adding python 3.12 to integration and unit test workflows

Why?

  • Make sure that we test against the newest python version

@angelofenoglio angelofenoglio requested a review from a team August 27, 2024 16:27
@angelofenoglio angelofenoglio self-assigned this Aug 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10776745542

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.031%

Totals Coverage Status
Change from base Build 10565657542: 0.0%
Covered Lines: 2018
Relevant Lines: 2812

💛 - Coveralls

@angelofenoglio
Copy link
Contributor Author

Had to fix the way assertions on patched objects are called to account for: python/cpython#100690
Going forward those calls should all start with assert_.

@angelofenoglio angelofenoglio merged commit b00b023 into master Sep 9, 2024
33 checks passed
@exequielrafaela exequielrafaela deleted the add-python-3.12-to-testing-workflows branch October 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants