Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE/ added new KOPS K8s layer #600

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

juanmatias
Copy link
Contributor

What?

  • Re factored K8s KOPS layer

Why?

  • To update and improve it

@juanmatias juanmatias requested a review from a team as a code owner July 1, 2024 19:37
Copy link

github-actions bot commented Jul 1, 2024

💰 Infracost report

Monthly estimate generated

Estimate details (includes details of unsupported resources and skipped projects due to errors)
──────────────────────────────────
131 projects have no cost estimate changes.
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
2338 cloud resources were detected:
∙ 615 were estimated
∙ 1607 were free
∙ 116 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 42 x aws_identitystore_group_membership
  ∙ 23 x aws_identitystore_user
  ∙ 10 x aws_guardduty_member
  ∙ 8 x aws_ssoadmin_permission_set
  ∙ 7 x aws_identitystore_group
  ∙ 5 x aws_fms_policy
  ∙ 5 x aws_s3_bucket_lifecycle_configuration
  ∙ 4 x aws_guardduty_detector
  ∙ 2 x aws_guardduty_organization_admin_account
  ∙ 2 x aws_guardduty_organization_configuration
  ∙ 2 x aws_organizations_delegated_administrator
  ∙ 1 x aws_eks_access_entry
  ∙ 1 x aws_fms_admin_account
  ∙ 1 x aws_organizations_organization
  ∙ 1 x aws_route53_resolver_firewall_domain_list
  ∙ 1 x aws_route53_resolver_firewall_rule
  ∙ 1 x aws_route53_resolver_firewall_rule_group
This comment will be updated when code changes.

Copy link
Member

@exequielrafaela exequielrafaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanmatias I left some small comments. Overall it looks greats, thanks for your contribution!

@juanmatias juanmatias merged commit 8fee4dd into master Jul 3, 2024
6 checks passed
@juanmatias juanmatias deleted the FEATURE/k8s-kops-new-layer branch July 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants