Skip to content

Commit

Permalink
feat(apps-devstg/s3-bucket-demo): update layer versions
Browse files Browse the repository at this point in the history
* Update tf version constrains v1.1.3
* Update tf aws provider constrains v4.10
* Update source module version to v3.3.0
* Add 'delete_marker_replication' argument in order to avoid errors 
during tf apply
  • Loading branch information
rodriguez-matias committed Jul 25, 2022
1 parent 999de93 commit 5d17009
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 10 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Pre-req: Logs bucket
#
module "log_bucket_demo_files" {
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v2.4.0"
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v3.3.0"

bucket = "${local.bucket_name}-logs"
acl = "log-delivery-write"
Expand Down Expand Up @@ -64,7 +64,7 @@ module "log_bucket_demo_files" {
# S3 Bucket Module Instantiation #
#=======================================#
module "s3_bucket_demo_files" {
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v2.4.0"
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v3.3.0"

bucket = local.bucket_name
acl = "private"
Expand All @@ -81,6 +81,8 @@ module "s3_bucket_demo_files" {
id = "ReplicationRule"
status = "Enabled"

delete_marker_replication = false

source_selection_criteria = {
sse_kms_encrypted_objects = {
enabled = true
Expand Down Expand Up @@ -180,7 +182,7 @@ module "s3_bucket_demo_files" {
# S3 Bucket Module Instantiation Replica #
#========================================#
module "s3_bucket_demo_files_replica" {
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v2.4.0"
source = "github.com/binbashar/terraform-aws-s3-bucket.git?ref=v3.3.0"

providers = {
aws = aws.secondary_region
Expand Down
12 changes: 5 additions & 7 deletions apps-devstg/us-east-1/storage/s3-bucket-demo-files --/config.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@ provider "aws" {
}

provider "aws" {
alias = "secondary_region"
region = var.region_secondary
profile = var.profile
shared_credentials_file = "~/.aws/bb/config"
alias = "secondary_region"
region = var.region_secondary
profile = var.profile
}

#=============================#
# Backend Config (partial) #
#=============================#
terraform {
required_version = ">= 1.0.9"
required_version = "~> 1.1.3"

required_providers {
aws = "~> 3.2"
aws = "~> 4.10"
}

backend "s3" {
Expand Down Expand Up @@ -66,4 +65,3 @@ data "terraform_remote_state" "security-identities" {
key = "security/identities/terraform.tfstate"
}
}

0 comments on commit 5d17009

Please sign in to comment.