Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBL-105 | Fix: increase size footer social media icons #177

Merged
merged 3 commits into from
May 4, 2023

Conversation

rodriguez-matias
Copy link
Contributor

What?

  • Increase size of footer social media icons.
  • Resolves the mobile display problem that was detected by Search Console, where buttons were small and too close together.

Why?

  • Improve SEO positioning and resolve mobile display issues.

References

  • Task BBL-105 | Issues fix at binbash.com.ar

How to check

  • Open Google Chrome -> Developer tools-> Device toolbar icon -> Select mobile style-> Choose device "iPhone XR"

image
image
image

@rodriguez-matias rodriguez-matias requested a review from a team as a code owner May 3, 2023 13:18
@rodriguez-matias rodriguez-matias self-assigned this May 3, 2023
@exequielrafaela exequielrafaela requested a review from a team May 3, 2023 14:22
Copy link
Member

@exequielrafaela exequielrafaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodriguez-matias Matu consider we'll need to sync the same change from home.html to home-es.html => https://github.com/binbashar/le-ref-architecture-doc/blob/master/material/overrides/home-es.html

@rodriguez-matias
Copy link
Contributor Author

@rodriguez-matias Matu consider we'll need to sync the same change from home.html to home-es.html => https://github.com/binbashar/le-ref-architecture-doc/blob/master/material/overrides/home-es.html

Yes, @exequielrafaela you're absolutely right.
It has already been corrected. Ready for your approval.

@rodriguez-matias rodriguez-matias merged commit 784337d into master May 4, 2023
@exequielrafaela exequielrafaela deleted the BBL-105/update-size-social-icons branch May 11, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants