Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust URLs #591

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Adjust URLs #591

merged 4 commits into from
Feb 11, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Jan 21, 2024

Proposed change

Adjust URLs to MyBMW 3.11. Looks good for ROW/NA.

This should also work for china (provided the login issue #588 is solved).

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d3bd67) 100.00% compared to head (e026fd6) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1412      1415    +3     
=========================================
+ Hits          1412      1415    +3     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (ø)
3.12 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikroe rikroe mentioned this pull request Jan 21, 2024
6 tasks
@rikroe rikroe requested a review from gerard33 January 22, 2024 19:56
gerard33
gerard33 previously approved these changes Jan 22, 2024
@rikroe rikroe merged commit 5d78330 into bimmerconnected:master Feb 11, 2024
13 checks passed
@rikroe rikroe mentioned this pull request Feb 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants