Prepare for Uint8List SDK breaking change #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the Dart SDK updated `HttpClientResponse` to implement `Stream<Uint8List>` rather than implementing `Stream<List<int>>`. This forwards-compatible chnage updates calls to `Stream.transform(StreamTransformer)` to instead call the functionally equivalent `StreamTransformer.bind(Stream)` API, which puts the stream in a covariant position and thus causes the SDK change to be non-breaking. dart-lang/sdk#36900
|
ping @IntelX |
|
@jwashin are you the right person to review and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the Dart SDK updated
HttpClientResponseto implement
Stream<Uint8List>rather than implementingStream<List<int>>.This forwards-compatible change updates calls to
Stream.transform(StreamTransformer)to instead call thefunctionally equivalent
StreamTransformer.bind(Stream)API, which puts the stream in a covariant position and
thus causes the SDK change to be non-breaking.
dart-lang/sdk#36900