Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown unix streams before dropping #237

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Shutdown unix streams before dropping #237

merged 3 commits into from
Oct 31, 2024

Commits on Oct 31, 2024

  1. secret: Call shutdown before droping socket 

    Fixes an issue where recording with bustle would block ashpd's retrieve
secret method.
    @A6GibKm
    A6GibKm committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e9a97aa View commit details
    Browse the repository at this point in the history

  2. secret: retrieve: Accept AsFd as argument 

    This is more general. Since BorrowedFd implements AsFd this should not
really break users.
    @A6GibKm
    A6GibKm committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    82a59e3 View commit details
    Browse the repository at this point in the history

  3. secret: Allocate bufer only once 

    gnome-keyring will always pass 64 bytes so we allocated only once. If
other implementations require:

 - less: Then we still allocate fewer times, and extra bytes do not harm
 - more: Then we still allocate fewer times than before
    @A6GibKm
    A6GibKm committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1f7d845 View commit details
    Browse the repository at this point in the history