Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization in input_capture portal #199

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

feschber
Copy link
Contributor

closes #187

@A6GibKm
Copy link
Collaborator

A6GibKm commented Mar 16, 2024

Thanks! Just for the record, could you please add a small description on how this was tested here?

@feschber
Copy link
Contributor Author

the example I linked in the issue correctly deserializes the activation token now

@feschber
Copy link
Contributor Author

https://github.com/feschber/lan-mouse/tree/libei-producer this works correctly now

@bilelmoussaoui
Copy link
Owner

Oh nooo. That is really stupid from my side. Would you mind checking other types that uses signature = dict and see if they use the correct deserialization derive macro?

Thanks a lot

@feschber
Copy link
Contributor Author

Oh nooo. That is really stupid from my side. Would you mind checking other types that uses signature = dict and see if they use the correct deserialization derive macro?

Thanks a lot

No problem, I could 100% see myself doing the same.
I did a quick grep and the rest seemed to look fine

@bilelmoussaoui bilelmoussaoui merged commit 58d7e61 into bilelmoussaoui:master Mar 16, 2024
6 checks passed
@bilelmoussaoui
Copy link
Owner

I will backport and do a release later today

bilelmoussaoui pushed a commit that referenced this pull request Mar 16, 2024
* fix Deserialize -> DeserializeDict

* fix Deserialize -> DeserializeDict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input_capture portal Signals are not working
3 participants