Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API return data for landing_zone_create with missing project iRODS collections #2036

Closed
4 tasks done
mikkonie opened this issue Nov 18, 2024 · 1 comment
Closed
4 tasks done
Assignees
Labels
app: landingzones Issue in the landingzones app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Nov 18, 2024

Reported by @Nicolai-vKuegelgen. Currently the landingzones API returns HTTP 400 if attempting to run landing_zone_create on a project for which iRODS collections have not been created.

The request itself is not technically invalid in this case. Hence, instead of 400 we should return 503 with a descriptive error message.

This is in line with the changes I recently made in #1847 and should be trivial to implement, so this would fit nicely in v1.0.0.

This is technically a breaking change, so I'll have to be sure to document it as such.

Tasks

  • Update view to return 503 instead of 400
  • Ensure descriptive error message
  • Update tests
  • Update documentation (including release notes)
@mikkonie mikkonie added feature Requested feature or enhancement app: landingzones Issue in the landingzones app labels Nov 18, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Nov 18, 2024
@mikkonie mikkonie self-assigned this Nov 18, 2024
@mikkonie mikkonie added the breaking Breaking change, to be implemented and documented with care label Nov 18, 2024
mikkonie added a commit that referenced this issue Nov 18, 2024
@mikkonie
Copy link
Contributor Author

Done. The message itself looked fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: landingzones Issue in the landingzones app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant