Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scope=None in AppSettingAPI.get_definitions() #1535

Closed
mikkonie opened this issue Jan 9, 2025 · 1 comment
Closed

Allow scope=None in AppSettingAPI.get_definitions() #1535

mikkonie opened this issue Jan 9, 2025 · 1 comment
Assignees
@mikkonie
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Milestone
v1.1.0

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Jan 9, 2025

It is weird that we require the scope here. There are use cases for returning all settings with one call, so scope=None should be allowed. Needed by e.g. #1534.

This change is not breaking.
@mikkonie mikkonie added feature Requested feature or enhancement app: projectroles Issue in the projectroles app labels Jan 9, 2025
@mikkonie mikkonie added this to the v1.1.0 milestone Jan 9, 2025
@mikkonie mikkonie self-assigned this Jan 9, 2025
@mikkonie mikkonie mentioned this issue Jan 9, 2025
Closed
6 tasks
mikkonie added a commit that referenced this issue Jan 9, 2025
@mikkonie
update get_definitions() for scope=None (#1535)
b50794c
@mikkonie
Copy link
Collaborator Author

mikkonie commented Jan 9, 2025

Done.

@mikkonie mikkonie closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@mikkonie