Skip to content

Commit

Permalink
fix ProjectRoleView tour help attachments (#1512)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikkonie committed Nov 12, 2024
1 parent 5865aea commit 56b4bbb
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Fixed
- **Projectroles**
- Deprecated ``SODAR_API_*`` settings required in tests (#1495)
- Add workaround to ``ProjectInviteCreateView`` returning 404 with category and query string (#1510)
- Broken tour help attachments in ``ProjectRoleView`` (#1512)


v1.0.2 (2024-09-09)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
{% load projectroles_common_tags %}
{% load projectroles_role_tags %}

<button class="btn btn-secondary dropdown-toggle sodar-list-dropdown"
<button class="btn btn-secondary dropdown-toggle sodar-list-dropdown
sodar-pr-role-btn"
type="button" data-toggle="dropdown"
aria-haspopup="true" aria-expanded="false">
<i class="iconify" data-icon="mdi:gear"></i>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{% load rules %}
{% load projectroles_common_tags %}

<button class="btn btn-secondary dropdown-toggle sodar-list-dropdown"
<button class="btn btn-secondary dropdown-toggle sodar-list-dropdown
sodar-pr-role-btn-owner"
type="button" data-toggle="dropdown"
aria-haspopup="true" aria-expanded="false">
<i class="iconify" data-icon="mdi:gear"></i>
Expand Down
2 changes: 1 addition & 1 deletion projectroles/templates/projectroles/_project_role_ops.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="ml-auto">
<button class="btn btn-primary dropdown-toggle"
<button class="btn btn-primary dropdown-toggle sodar-pr-role-ops-btn"
id="sodar-pr-role-ops-btn"
type="button" data-toggle="dropdown"
aria-haspopup="true" aria-expanded="false"
Expand Down
12 changes: 6 additions & 6 deletions projectroles/templates/projectroles/project_roles.html
Original file line number Diff line number Diff line change
Expand Up @@ -141,17 +141,17 @@ <h3>
showCancelLink: true
});
}
if ($('.sodar-pr-role-dropdown-owner').length) {
if ($('.sodar-pr-role-btn-owner').length) {
tour.addStep('role_dropdown_owner', {
title: 'Owner Dropdown',
text: 'Ownership can be transferred to another user from this ' +
'dropdown.',
attachTo: '.sodar-pr-role-dropdown-owner left',
attachTo: '.sodar-pr-role-btn-owner left',
advanceOn: '.docs-link click',
showCancelLink: true,
});
}
if ($('.sodar-pr-role-dropdown').length) {
if ($('.sodar-pr-role-btn').length) {
tour.addStep('role_dropdown', {
title: 'Member Dropdown',
text: 'For a non-owner member, you can update or remove the ' +
Expand All @@ -160,18 +160,18 @@ <h3>
'allowed. To remove such a role, navigate to the parent ' +
'{% get_display_name 'CATEGORY' %} and remove the ' +
'membership there.',
attachTo: '.sodar-pr-role-dropdown left',
attachTo: '.sodar-pr-role-btn left',
advanceOn: '.docs-link click',
showCancelLink: true,
});
}
if ($('#sodar-pr-role-ops-dropdown').length) {
if ($('#sodar-pr-role-ops-btn').length) {
tour.addStep('role_ops', {
title: 'Member Operations Dropdown',
text: 'From this dropdown you can access operations for adding ' +
'new members to the {% get_display_name 'PROJECT' %} and ' +
'inviting users not yet on the site.',
attachTo: '#sodar-pr-role-ops-dropdown left',
attachTo: '#sodar-pr-role-ops-btn left',
advanceOn: '.docs-link click',
showCancelLink: true
});
Expand Down

0 comments on commit 56b4bbb

Please sign in to comment.