Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump mehari to v0.25.5 for bugs fixed there #510

Merged
merged 2 commits into from
May 27, 2024
Merged

fix: bump mehari to v0.25.5 for bugs fixed there #510

merged 2 commits into from
May 27, 2024

Conversation

holtgrewe
Copy link
Member

No description provided.

@holtgrewe holtgrewe marked this pull request as draft May 16, 2024 06:50
xiamaz
xiamaz approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tedil
tedil approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@tedil tedil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The only thing I was wondering about was the use of --force; I usually prefer trash-in trash-out approaches, so using force to proceed even for

malformed tags with incorrect number of fields

doesn't sit quite right with me.

@holtgrewe holtgrewe marked this pull request as ready for review May 27, 2024 08:23
@holtgrewe holtgrewe merged commit 95b451b into main May 27, 2024
6 checks passed
@holtgrewe holtgrewe deleted the fix-mehari-bump-0.25.5 branch May 27, 2024 08:23
@tedil tedil mentioned this pull request Jun 28, 2024
Merged
tedil pushed a commit that referenced this pull request Aug 2, 2024
@holtgrewe @tedil
fix: bump mehari to v0.25.5 for bugs fixed there (#510)
7d60df3
This was referenced Dec 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedil tedil tedil approved these changes

@xiamaz xiamaz xiamaz approved these changes

@Nicolai-vKuegelgen Nicolai-vKuegelgen Awaiting requested review from Nicolai-vKuegelgen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holtgrewe @xiamaz @tedil