Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make roh_calling a report of variant_calling #310

Closed
holtgrewe opened this issue Dec 30, 2022 · 0 comments · Fixed by #311
Closed

Make roh_calling a report of variant_calling #310

holtgrewe opened this issue Dec 30, 2022 · 0 comments · Fixed by #311

Comments

@holtgrewe
Copy link
Member

Is your feature request related to a problem? Please describe.
The roh_calling step only implements bcftools roh. It could very well just be a report in variant_calling.

Describe the solution you'd like
Make bcftools roh a report in variant_calling.

Describe alternatives you've considered
N/A

Additional context
N/A
holtgrewe added a commit that referenced this issue Dec 30, 2022
@holtgrewe
refactor!: move "bcftools roh" as report in variant_calling (#310)
f87c8bb
@holtgrewe holtgrewe linked a pull request Dec 30, 2022 that will close this issue
refactor!: move "bcftools roh" as report in variant_calling (#310) #311
Merged
holtgrewe added a commit that referenced this issue Dec 30, 2022
@holtgrewe
refactor!: move "bcftools roh" as report in variant_calling (#310) (#311
ee7e1fa 
)

This removes the old step `roh_calling`.
@github-actions github-actions bot mentioned this issue Dec 30, 2022
Closed
@tedil tedil mentioned this issue Jun 28, 2024
Merged
This was referenced Dec 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: move "bcftools roh" as report in variant_calling (#310) bihealth/snappy-pipeline
1 participant
@holtgrewe