Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add type definitions (#68) #71

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: Add type definitions (#68) #71

merged 2 commits into from
Sep 25, 2023

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Sep 25, 2023 •
edited
Loading

Tasks:

  • Small Variant type

@gromdimon gromdimon linked an issue Sep 25, 2023 that may be closed by this pull request
Add Types for existing data structures #68
Closed
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #71 (8d91890) into main (54a2d88) will increase coverage by 9.42%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   88.16%   97.59%   +9.42%     
==========================================
  Files          40        2      -38     
  Lines        1529       83    -1446     
  Branches      457        0     -457     
==========================================
- Hits         1348       81    -1267     
+ Misses        175        2     -173     
+ Partials        6        0       -6

see 38 files with indirect coverage changes

@gromdimon gromdimon linked an issue Sep 25, 2023 that may be closed by this pull request
Add Page not Found view #69
Closed
@gromdimon
Copy link
Contributor Author

gromdimon commented Sep 25, 2023 •
edited
Loading

Additional Issue: #69

Tasks:

  • Add 404 page
  • Test it

@gromdimon gromdimon marked this pull request as ready for review September 25, 2023 11:31
@gromdimon gromdimon enabled auto-merge (squash) September 25, 2023 11:31
@gromdimon gromdimon merged commit 607af69 into main Sep 25, 2023
9 checks passed
@gromdimon gromdimon deleted the 68-add-types-for-existing-data-structures branch September 25, 2023 11:32
@varfish-bot varfish-bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Page not Found view Add Types for existing data structures
1 participant
@gromdimon