Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more robust handling of async sessions (#360) #361

Conversation

holtgrewe
Copy link
Member

No description provided.

@holtgrewe holtgrewe linked an issue Jan 3, 2024 that may be closed by this pull request
@holtgrewe holtgrewe enabled auto-merge (squash) January 3, 2024 13:48
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (970b400) 77.16% compared to head (04f83e7) 94.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #361       +/-   ##
===========================================
+ Coverage   77.16%   94.35%   +17.19%     
===========================================
  Files         172       53      -119     
  Lines        6782     1505     -5277     
  Branches     1514        0     -1514     
===========================================
- Hits         5233     1420     -3813     
+ Misses       1347       85     -1262     
+ Partials      202        0      -202     
Files Coverage Δ
backend/app/main.py 89.74% <100.00%> (+0.55%) ⬆️
backend/app/api/deps.py 75.00% <33.33%> (+8.33%) ⬆️

... and 119 files with indirect coverage changes

@holtgrewe holtgrewe merged commit 86510e8 into main Jan 3, 2024
9 checks passed
@holtgrewe holtgrewe deleted the 360-properly-use-context-managers-for-async-sqlalchemy-connections branch January 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly use context managers for async SQLAlchemy connections
1 participant