Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Non existing variants are not handled gracefully (#109) #112

Merged

Conversation

gromdimon
Copy link
Contributor

Also solving #111

@gromdimon gromdimon linked an issue Oct 4, 2023 that may be closed by this pull request
@gromdimon gromdimon linked an issue Oct 4, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #112 (200b21b) into main (781f383) will increase coverage by 3.56%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   83.12%   86.69%   +3.56%     
==========================================
  Files          88       32      -56     
  Lines        2347      466    -1881     
  Branches      556        0     -556     
==========================================
- Hits         1951      404    -1547     
+ Misses        374       62     -312     
+ Partials       22        0      -22     

see 56 files with indirect coverage changes

@gromdimon gromdimon merged commit 22b2001 into main Oct 4, 2023
9 checks passed
@gromdimon gromdimon deleted the 109-non-existing-variants-are-not-handled-gracefully branch October 4, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warning seen during frontend tests Non-existing variants are not handled gracefully
1 participant