Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues with case info storage #454

Closed
10 tasks done
holtgrewe opened this issue Feb 6, 2024 · 0 comments · Fixed by #456
Closed
10 tasks done

Resolve issues with case info storage #454

holtgrewe opened this issue Feb 6, 2024 · 0 comments · Fixed by #456
Assignees
Labels
bug Something isn't working
Milestone

Comments

@holtgrewe
Copy link
Member

holtgrewe commented Feb 6, 2024

Describe the bug
We currently have a couple of issues with the case info store.

Ensure the following
In a "virgin" browser window, i.e., without any session, we should not see any local javascript errors or JSON parsing. Seeing "not authorized" for profile etc. is OK.

  • go to gene details and look at CADA ranking (should display nothing as HPO list is empty, should not try to prioritize)
  • open case info window
  • reload before saving user story:
    • open case info window
    • enter terms
    • reload before saving
  • enter terms, save, reload, go to fresh page
  • update terms while on gene info

Now, after logging in, do the same as above

  • gene info with empty case
  • enter terms
  • go to gene info
  • update terms while on gene info

Also, wrap the "load from local storage" code such, that on errors, the local storage key is erased. This should fix issues with old state in old snake_case_format.

  • clear local storage key on error loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant