Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClinVar - Impact / Frequency color coding wrong #445

Closed
sczakihl opened this issue Feb 6, 2024 · 1 comment · Fixed by #449
Closed

ClinVar - Impact / Frequency color coding wrong #445

sczakihl opened this issue Feb 6, 2024 · 1 comment · Fixed by #449
Labels
bug Something isn't working

Comments

@sczakihl
Copy link
Collaborator

sczakihl commented Feb 6, 2024

Describe the bug
Colorcoding for ClinVar - Impact / Frequency display is misleading.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'reev'
  2. enter any gene or variant
  3. Scroll down to 'ClinVar'
  4. See error

Expected behavior
benign should be green
uncertain should be yellow or grey (use the same color as for impact counts on the right)
pathogenic should be red

Screenshots
grafik
@sczakihl sczakihl added the bug Something isn't working label Feb 6, 2024
holtgrewe added a commit to bihealth/reev-frontend-lib that referenced this issue Feb 6, 2024
@holtgrewe
fix: color coding of gene-clinvar plots (bihealth/reev#445)
b27a999
holtgrewe added a commit to bihealth/reev-frontend-lib that referenced this issue Feb 6, 2024
@holtgrewe
fix: color coding of gene-clinvar plots (bihealth/reev#445) (#97)
79658a3
holtgrewe added a commit that referenced this issue Feb 6, 2024
@holtgrewe
fix: bump rfl for gene-clinvar plot coloring (#445)
746b09b
@holtgrewe holtgrewe linked a pull request Feb 6, 2024 that will close this issue
fix: bump rfl for gene-clinvar plot coloring (#445) #449
Merged
holtgrewe added a commit that referenced this issue Feb 6, 2024
@holtgrewe
fix: bump rfl for gene-clinvar plot coloring (#445) (#449)
9765fe2
@varfish-bot varfish-bot mentioned this issue Feb 6, 2024
Merged
@holtgrewe
Copy link
Member

fixed

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump rfl for gene-clinvar plot coloring (#445) bihealth/reev
2 participants
@holtgrewe @sczakihl