Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reuseable components into reev-frontend-lib #412

Closed
4 of 5 tasks
holtgrewe opened this issue Jan 25, 2024 · 3 comments · Fixed by #435
Closed
4 of 5 tasks

Move reuseable components into reev-frontend-lib #412

holtgrewe opened this issue Jan 25, 2024 · 3 comments · Fixed by #435
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@holtgrewe
Copy link
Member

holtgrewe commented Jan 25, 2024

Is your feature request related to a problem? Please describe.
We currently have the use case for having the annonars displaying components also used in VarFish.

Describe the solution you'd like
Refactor them into a library:

  • proof of concept
    • publish to GitHub Packages rather than npm, but used automated workflow
    • document development setup with npm link
    • ensure production deployment works
  • actual migration

Describe alternatives you've considered
N/A

Additional context
N/A

@holtgrewe holtgrewe added the enhancement New feature or request label Jan 25, 2024
@holtgrewe holtgrewe added this to the 0.5.0 milestone Jan 25, 2024
@holtgrewe holtgrewe self-assigned this Jan 25, 2024
@holtgrewe holtgrewe changed the title Move reuseable components into reev-lib Move reuseable components into reev-frontend-lib Jan 25, 2024
@holtgrewe
Copy link
Member Author

Repository:

Creates npm package reev-frontend-lib.

@holtgrewe
Copy link
Member Author

While it is possible to install the package, this requires a npm login. Trying to rather install directly from Git.

@holtgrewe
Copy link
Member Author

For now, putting into frontend/src/ext as git submodule for lack of np installability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant