Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Seqvar and LinearStrucvar types rather than variant names #366

Closed
holtgrewe opened this issue Jan 4, 2024 · 0 comments · Fixed by #378
Closed

Use Seqvar and LinearStrucvar types rather than variant names #366

holtgrewe opened this issue Jan 4, 2024 · 0 comments · Fixed by #378
Assignees
@gromdimon
Labels
enhancement New feature or request internal Some internal note
Milestone
0.7.0

Comments

@holtgrewe
Copy link
Member

Is your feature request related to a problem? Please describe.
The frontend client API classes use variant names in places. This led to a problem when resolving #365 as the name schema changed.

Describe the solution you'd like
Switch to using the Seqvar and LinearStrucvar interfaces such that the type system can help us guard against issues.

Describe alternatives you've considered
N/A

Additional context
N/A
@holtgrewe holtgrewe added the enhancement New feature or request label Jan 4, 2024
@holtgrewe holtgrewe added this to the 0.6.0 milestone Jan 4, 2024
@gromdimon gromdimon self-assigned this Jan 8, 2024
@gromdimon gromdimon added the internal Some internal note label Jan 10, 2024
@gromdimon gromdimon linked a pull request Jan 10, 2024 that will close this issue
feat: Use Seqvar and LinearStrucvar whenever possible (#366) #378
Merged
gromdimon added a commit that referenced this issue Jan 10, 2024
@gromdimon
feat: Use Seqvar and LinearStrucvar whenever possible (#366) (#378)
c35ae0f
@varfish-bot varfish-bot mentioned this issue Jan 9, 2024
Closed
@varfish-bot varfish-bot mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gromdimon gromdimon

Labels
enhancement New feature or request internal Some internal note
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

feat: Use Seqvar and LinearStrucvar whenever possible (#366) bihealth/reev
2 participants
@holtgrewe @gromdimon