Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPO and OMIM search has low quality #338

Closed
holtgrewe opened this issue Dec 22, 2023 · 1 comment · Fixed by #346
Closed

HPO and OMIM search has low quality #338

holtgrewe opened this issue Dec 22, 2023 · 1 comment · Fixed by #346
Labels
enhancement New feature or request
Milestone
0.4.0

Comments

@holtgrewe
Copy link
Member

holtgrewe commented Dec 22, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, the HPO and OMIM search yields weird results.

Describe the solution you'd like
Look into this further and ensure that also aliases are searched for, search is case insensitive, and containment is enough.

Describe alternatives you've considered
N/A

Additional context
The fix needs to be done in viguno and then integrated here.
@holtgrewe holtgrewe added the enhancement New feature or request label Dec 22, 2023
@holtgrewe holtgrewe added this to the 0.4.0 milestone Dec 22, 2023
@holtgrewe
Copy link
Member Author

cf.

holtgrewe added a commit that referenced this issue Dec 27, 2023
@holtgrewe
feat: improve HPO lookup result quality with latest viguno (#338)
e8cc8de
@holtgrewe holtgrewe linked a pull request Dec 27, 2023 that will close this issue
feat: improve HPO lookup result quality with latest viguno (#338) #346
Merged
holtgrewe added a commit that referenced this issue Dec 27, 2023
@holtgrewe
feat: improve HPO lookup result quality with latest viguno (#338) (#346)
84d2c7b
@varfish-bot varfish-bot mentioned this issue Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

feat: improve HPO lookup result quality with latest viguno (#338) bihealth/reev
1 participant
@holtgrewe