Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict the upgrading/downgrading of ACMG seqvar criteria #291

Closed
holtgrewe opened this issue Dec 15, 2023 · 1 comment · Fixed by #321
Closed

Restrict the upgrading/downgrading of ACMG seqvar criteria #291

holtgrewe opened this issue Dec 15, 2023 · 1 comment · Fixed by #321
Assignees
@holtgrewe
Labels
enhancement New feature or request
Milestone
0.3.0

Comments

@holtgrewe
Copy link
Member

Is your feature request related to a problem? Please describe.
Not all combinations of ACMG seqvar criteria are allowed.

Describe the solution you'd like
The UI should only allow the "legal" ones, see additional context.

Describe alternatives you've considered
N/A

Additional context
@holtgrewe holtgrewe added the enhancement New feature or request label Dec 15, 2023
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 15, 2023
@holtgrewe holtgrewe assigned gromdimon and holtgrewe and unassigned gromdimon Dec 15, 2023
holtgrewe added a commit that referenced this issue Dec 21, 2023
@holtgrewe
feat: restrict upgrade/downgrade of AMCG seqvar criteria (#291)
64825ef
@holtgrewe holtgrewe linked a pull request Dec 21, 2023 that will close this issue
feat: restrict upgrade/downgrade of AMCG seqvar criteria (#291) #321
Merged
@holtgrewe
Copy link
Member Author

The restrictions from from the ACGS Best Practice Guidelines 2019

holtgrewe added a commit that referenced this issue Dec 21, 2023
@holtgrewe
feat: restrict upgrade/downgrade of AMCG seqvar criteria (#291) (#321)
fabc262
@varfish-bot varfish-bot mentioned this issue Dec 21, 2023
Merged
@holtgrewe holtgrewe mentioned this issue Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holtgrewe holtgrewe

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

feat: restrict upgrade/downgrade of AMCG seqvar criteria (#291) bihealth/reev
2 participants
@holtgrewe @gromdimon