Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PP5/BP6 #289

Closed
holtgrewe opened this issue Dec 15, 2023 · 0 comments · Fixed by #319
Closed

Drop PP5/BP6 #289

holtgrewe opened this issue Dec 15, 2023 · 0 comments · Fixed by #319
Assignees
@gromdimon
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@holtgrewe
Copy link
Member

Describe the bug
The ACMG seqvar criteria PP5/BP6 should not be used any more.

Expected behavior
Remove them from the UI and also do not incorporate them into the calculation. We should not even store them, probably.

Additional context
@holtgrewe holtgrewe added the bug Something isn't working label Dec 15, 2023
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 15, 2023
@gromdimon gromdimon linked a pull request Dec 20, 2023 that will close this issue
fix: Drop PP5 and BP6 criteria (#289) #319
Merged
holtgrewe added a commit that referenced this issue Dec 21, 2023
@gromdimon @holtgrewe
fix: Drop PP5 and BP6 criteria (#289) (#319)
a328f3a 
Co-authored-by: Manuel Holtgrewe <[email protected]>
@varfish-bot varfish-bot mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gromdimon gromdimon

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix: Drop PP5 and BP6 criteria (#289) bihealth/reev
2 participants
@holtgrewe @gromdimon