Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SearchBar to use Vuetify toolbars #17

Closed
gromdimon opened this issue Aug 29, 2023 · 0 comments
Closed

Modify SearchBar to use Vuetify toolbars #17

gromdimon opened this issue Aug 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gromdimon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the search bar component is being implemented using multiple building blocks: a text field, select options, and a search button. However, Vuetify offers a more elegant approach to handling such cases, specifically by utilizing toolbars. We should rework the search component to enhance its efficiency and maintainability.

Describe the solution you'd like

Refactor the SearchBar.vue component as follows:

  1. Revise the SearchBar.vue component code.
  2. Update corresponding tests to ensure proper functionality is maintained.
  3. Modify the usage of the SearchBar.vue component in HomeView.vue to align with the revised structure.

Additional task

Additionally, enhance the user experience by incorporating the SearchBar.vue component into the HeaderDetailPage.vue for details pages. This involves:

  1. Integrating the SearchBar.vue component into the HeaderDetailPage.vue.
    • Note that the HeaderDetailPage.vue is used exclusively with specific search results, so the SearchBar should be pre-filled with data such as searchTerm and genomeRelease.
    • Be mindful of proper implementation to ensure that props are correctly passed via references.
  2. Thoroughly testing the integration to verify its functionality and responsiveness.

Describe alternatives you've considered

None have been considered at this point.

Additional context

This enhancement presents an opportunity to streamline our implementation and improve efficiency across the application, ultimately leading to a more cohesive user experience.

@gromdimon gromdimon added the enhancement New feature or request label Aug 29, 2023
@gromdimon gromdimon self-assigned this Aug 29, 2023
@gromdimon gromdimon linked a pull request Aug 29, 2023 that will close this issue
3 tasks
@gromdimon gromdimon linked a pull request Aug 30, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant