Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make components more robust in case of store/api errors (#160) #161

Merged

Conversation

holtgrewe
Copy link
Member

No description provided.

@holtgrewe holtgrewe linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 65.41%. Comparing base (b9445ba) to head (28f9a87).

❗ Current head 28f9a87 differs from pull request most recent head 5bb9ac4. Consider uploading reports for the commit 5bb9ac4 to get more accurate results

Files Patch % Lines
src/lib/urlConfig.ts 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   65.49%   65.41%   -0.08%     
==========================================
  Files          52       52              
  Lines        2353     2371      +18     
  Branches      781      781              
==========================================
+ Hits         1541     1551      +10     
- Misses        740      748       +8     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe marked this pull request as ready for review March 5, 2024 06:51
@holtgrewe holtgrewe enabled auto-merge (squash) March 5, 2024 06:51
@holtgrewe holtgrewe merged commit 002a362 into main Mar 5, 2024
5 checks passed
@holtgrewe holtgrewe deleted the 160-make-components-more-robust-in-case-of-storeapi-errors branch March 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make components more robust in case of store/api errors
1 participant