Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annonars call wrong for grch38 and chromosomes prefixed with chr #184

Closed
stolpeo opened this issue Apr 8, 2024 · 1 comment · Fixed by #185
Closed

annonars call wrong for grch38 and chromosomes prefixed with chr #184

stolpeo opened this issue Apr 8, 2024 · 1 comment · Fixed by #185
Labels
bug Something isn't working

Comments

@stolpeo
Copy link
Contributor

stolpeo commented Apr 8, 2024

Describe the bug

When using grch38 and the chromosomes in the database are prefixed with chr, a chr is still added to the chromosome name:

proxy/varfish/annonars/annos/variant?genome_release=grch38&chromosome=chrchr1&pos=1234&reference=G&alternative=A
@stolpeo stolpeo added the bug Something isn't working label Apr 8, 2024
@stolpeo
Copy link
Contributor Author

stolpeo commented Apr 8, 2024

RCA

reev-frontend-lib/src/api/annonars/client.ts

Line 71 in 8c5d219

chromosome = `chr${chrom}`

this should be

chromosome = `chr${chromosome}`

stolpeo added a commit that referenced this issue Apr 8, 2024
@stolpeo
fix: annonars call wrong for grch38 and chromosomes prefixed with chr (…
3da4610 
…#184)
@stolpeo stolpeo mentioned this issue Apr 8, 2024
Merged
@stolpeo stolpeo linked a pull request Apr 8, 2024 that will close this issue
fix: annonars call wrong for grch38 and chromosomes prefixed with chr… #185
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: annonars call wrong for grch38 and chromosomes prefixed with chr… bihealth/reev-frontend-lib
1 participant
@stolpeo