-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cubi-tk sodar update-samplesheet
#240
Conversation
Add sodar/update-samplesheet and tests
- update-samplesheet now uses new MV default (old sheet layout with Analysis-ID as sample-ID, other IDs as metadata) - several fixes
Please format your code with black: |
Missing so far:
|
cubi-tk sodar update-samplesheet
cubi-tk sodar update-samplesheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with ISA, so most of my comments are more from a coding perspective and some general remarks.
I really like all the sanity checks and validations that you do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only thing I'd like to see as a little bonus is an example in the documentation/manual or so.
"Dummy-ID=Source Name", | ||
"Sample Name", | ||
"Extract Name", | ||
"barcode=Barcode sequence", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this might behave unexpectedly depending on shell/quoting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nvm, arg_list
is forwarded as is to argparse
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sry, didn't fully read your comment, I can add something to the documentation though
New function to allow flexible updates of ISA samplesheets. Also introduce a base class to implement SodarAPI features, as the currently used sodar_cli package is heavily outdated.
Features:
TBD:
Note: this is a potential replacement/side-grade of
cubi-tk sodar add-ped