Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --filter-status option for controlling which landing zones are listed #239

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

tedil
Copy link
Member

@tedil tedil commented Sep 6, 2024

TODO:

  • find out what the status enum's variants are
  • add test

@tedil
Copy link
Member Author

tedil commented Sep 6, 2024

This is one way to address #234, comments welcome

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Please format your code with black: make black.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, not sure if tests need to be adjusted

cubi_tk/sodar/lz_list.py Outdated Show resolved Hide resolved
@tedil tedil force-pushed the landing-zone-filter-status branch from 0c4c9e8 to 0a8ce1e Compare January 14, 2025 10:59
@tedil tedil marked this pull request as ready for review January 14, 2025 10:59
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedil tedil merged commit 900b67a into main Jan 14, 2025
4 checks passed
@tedil tedil deleted the landing-zone-filter-status branch January 14, 2025 14:46
This was referenced Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants