Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: properly represent clinvar VCV/RCV structure in protobufs (#242) #259

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Oct 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (bf74e69) 71.07% compared to head (c777a58) 71.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   71.07%   71.14%   +0.07%     
==========================================
  Files          61       61              
  Lines        5738     5778      +40     
==========================================
+ Hits         4078     4111      +33     
- Misses       1660     1667       +7     
Files Coverage Δ
src/clinvar_genes/cli/import.rs 92.99% <96.00%> (-0.16%) ⬇️
src/clinvar_minimal/cli/import.rs 94.11% <95.00%> (-0.33%) ⬇️
src/clinvar_minimal/cli/reading.rs 41.75% <44.11%> (+5.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe marked this pull request as ready for review October 18, 2023 07:09
@holtgrewe holtgrewe merged commit 9095773 into main Oct 18, 2023
9 checks passed
@holtgrewe holtgrewe deleted the 242-clinvar-structure-not-properly-represented-rcvvcv branch October 18, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClinVar structure not properly represented RCV/VCV
1 participant