Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle emergency commands #2607

Merged
merged 20 commits into from
Feb 9, 2023

Conversation

kisslorand
Copy link
Contributor

@kisslorand kisslorand commented Sep 30, 2022

Requirements

BTT or MKS TFT

Description

This PR is a bugfix and an enhancement.

The bugfix:
A recent Marlin commit of a PR (MarlinFirmware/Marlin#24761) broke the cancellation of the print when printing from onboard media, the TFT doesn't send any command after cancel procedure is started. This PR fixes it.

The enhancement:
This PR brings emergency commands handling. Emergency gcodes are recognized, parsed and treated with priority.

Benefits:

  • faster parsing of emergency gcodes from any source and almost instant cancellation of an ongoing onboard print

Related Issues

TFT/src/User/API/Printing.c Outdated Show resolved Hide resolved
TFT/src/User/API/Printing.c Outdated Show resolved Hide resolved
TFT/src/User/API/Printing.c Outdated Show resolved Hide resolved
@kisslorand kisslorand mentioned this pull request Nov 24, 2022
@bigtreetech bigtreetech merged commit d58556a into bigtreetech:master Feb 9, 2023
kisslorand added a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Screen freeze on onboard SD print abort
3 participants