-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added file upload feature + code optimization + bug fixes #2431
Merged
bigtreetech
merged 16 commits into
bigtreetech:master
from
digant73:bugfix-2022-03-06_b
Mar 21, 2022
Merged
Added file upload feature + code optimization + bug fixes #2431
bigtreetech
merged 16 commits into
bigtreetech:master
from
digant73:bugfix-2022-03-06_b
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digant73
changed the title
Code optimization + bug fixes
Added file upload feature + code optimization + bug fixes
Mar 8, 2022
mehmetsutas
pushed a commit
to mehmetsutas/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPROVEMENTS:
M28 SD:<file path> or M28 U:<file path>
to select and open the target file. UseM29
to close the file. Any command betweenM28
andM29
will be written on the file. Commands with checksum are also allowed although the TFT will simply skip it (checksum is currently not used/supported by TFT). Obviously, checksum (if any) is always removed when the command is written in the file (e.g.N0 M106*36
->M106
). When in writing mode (both the TFT or onboard media), the reminder messageTFT in Listening Mode!
is displayed (see picture below) until the writing is completed (M29 received). That message means also that all the commands generated by the TFT are discarded (neither processed by TFT nor sent to mainboard).BUGFIXES:
M28
andM29
) to save on the file are provided with checksum (used as CRC during the command transfer).PR STATE: Ready for merge