Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved robustness of Printing menu during a dialog with Marlin #1922

Merged
merged 1 commit into from
May 17, 2021

Conversation

digant73
Copy link
Contributor

IMPROVEMENTS:

  • improved robustness of Printing menu during a dialog with Marlin (e.g. printing from onboard SD). Now when a dialog with Marlin is ongoing (e.g. M600) pressing on the "Resume" button will be simply ignored and an error message "busy processing, please wait..." is displayed on the notification bar just to inform the user that a dialog with Marlin is ongoing and it must be first completed.
  • config.ini has been updated reporting Marlin 2.0.8.1 as the suggested minimum version fully compliant with TFT fw

PR STATUS: ready to merge

NOTE:

  1. bug [BUG] Print pause not working with REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER disabled MarlinFirmware/Marlin#21813 needs to be fixed in order to cover all the possible Marlin settings
  2. PR fixes #21813 MarlinFirmware/Marlin#21828 fixing the above bug on Marlin must be merged on Marlin

EDIT 2021-05-16:

  • Marlin PR #21828 is present in the new official Marlin 2.0.8.1 so this PR is ready to be merged now
  • config.ini has been updated reporting Marlin 2.0.8.1 as the suggested minimum version fully compliant with TFT fw

@bigtreetech bigtreetech merged commit e3a13be into bigtreetech:master May 17, 2021
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants