Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the ReadMe to cover the new Language .ini, added The Round Miracle and the Hybrid Red Theme and removed the Classic theme #1187

Closed
wants to merge 56 commits into from

Conversation

oldman4U
Copy link
Contributor

@oldman4U oldman4U commented Oct 19, 2020

resolves #896
resolves #1175

oldman4U and others added 12 commits September 18, 2020 22:52
added the information how the update looks on TFT
Improved the readability of the screenshots.
Added the information about the renaming shown on SD card and the information how the elemements can be reused.
@oldman4U oldman4U mentioned this pull request Oct 19, 2020
@AntoszHUN
Copy link
Contributor

Oh yes. Thanks. If it gets in afterwards I keep updating. I keep it up to date.

@traffic-light
Copy link
Contributor

Why are there so many changes in your PR :-P

I think something went wrong :(

@AntoszHUN
Copy link
Contributor

I don't know, I just made the icons. : D

@oldman4U
Copy link
Contributor Author

@AntoszHUN This would be great. But we also have to add a picture to the ReadMe where only the two others are shown at the moment.

@traffic-light It is all good. Changed a zip to a folder with many files in it. UI theme. Thought you have to learn.....

@traffic-light
Copy link
Contributor

@traffic-light It is all good. Changed a zip to a folder with many files in it. UI theme. Thought you have to learn.....

Okay. that's why ;-)

About "Thought you have to learn.....":
Not 24/7

@oldman4U
Copy link
Contributor Author

It is good to have 4 eyes checking what i did. This is all new to me.....

;-)

@traffic-light
Copy link
Contributor

Maybe useful to add some text for the readme and feature request?

@oldman4U
Copy link
Contributor Author

What do you mean exactly?

@oldman4U
Copy link
Contributor Author

oldman4U commented Oct 28, 2020

@AntoszHUN

I just started the process to remove the Classic Menu & Icon Theme. If you agree, we can add your Hybrid Red Theme instead. For this I would need a screenshot and a short description and you have to be aware, that you have to add Icons for new versions for at least some time. Maybe it would be best to make a kind of design guide and to provide the raw material, so another person can also work on it?

Question: Have you made one Icon and then you scaled it to the different sizes, or have you made all 500+ icons individually?

Please let me know

@AntoszHUN
Copy link
Contributor

@AntoszHUN

I just started the process to remove the Classic Menu & Icon Theme. If you agree, we can add your Hybrid Red Theme instead. For this I would need a screenshot and a short description and you have to be aware, that you have to add Icons for new versions for at least some time. Maybe it would be best to make a kind of design guide and to provide the raw material, so another person can also work on it?

Question: Have you made one Icon and then you scaled it to the different sizes, or have you made all 500+ icons individually?

Please let me know

Hi! I had to create the icons in two sizes. It was then resized for different displays to be compatible with all displays. Unfortunately, I can’t give you anything specific. I basically started with the main theme and updated the icons for that. Not simple. On the other hand, since I strive for uniqueness, I would be reluctant to pass this editing on to others. Then it's like I'm not doing it. Of course I update as often as I can. But if something changes every week, I don’t see the point. You need to work out a session so that you can do it without getting in trouble. I like to do it. But every other day or every week I can’t update. Because I noticed that anno icons were included and then they were taken out 2 weeks later. Then 1-2 icons were added again and later disappeared again. I don't see the point in that. If I design an icon that is not 2 minutes, I will not delete it in 2 days or 2 weeks with just one click.

@oldman4U
Copy link
Contributor Author

I completely understand your point and I know that it is a lot of work. This is the reason why I ask;-)

You can also step back from first row and make it like The Round Miracle and just post it here. Then we would have to remove it from the package again.

Take your time and think about it and let me know once you are sure. OK?

Köszönöm Szepen

@AntoszHUN
Copy link
Contributor

I completely understand your point and I know that it is a lot of work. This is the reason why I ask;-)

You can also step back from first row and make it like The Round Miracle and just post it here. Then we would have to remove it from the package again.

Take your time and think about it and let me know once you are sure. OK?

Köszönöm Szepen

Of course. All right. If the community likes it too, I would definitely like it to be included. Thanks!

@oldman4U
Copy link
Contributor Author

I think so!

The name of the theme is already defined, so what I would need is a screenshot like this. Could you please make this and attach it here.

Thank you
Screenshot 2020-10-28 at 20 26 19

@oldman4U oldman4U marked this pull request as ready for review November 12, 2020 11:43
@oldman4U
Copy link
Contributor Author

I had to remove all the case_light.bmp files from the Unified Menu theme to remove the conflicts...

There is something wrong I am afraid.

@AntoszHUN
Copy link
Contributor

I had to remove all the case_light.bmp files from the Unified Menu theme to remove the conflicts...

There is something wrong I am afraid.

What could be the problem? Images are converted and formatted correctly. Is there a different name in the firmware?

@oldman4U
Copy link
Contributor Author

You should people like me not allow to contribute...

The problem is most likely, that I made a local repository from a file and not a link, so it was never updated.

I learn every day something new.

@oldman4U
Copy link
Contributor Author

Not sure what the best way would be now, delete everything and copy the new stuff finally over or is there a way to load the last build into my local repository?

@AntoszHUN
Copy link
Contributor

I don't know what a good solution would be. :(

Not sure what the best way would be now, delete everything and copy the new stuff finally over or is there a way to load the last build into my local repository?

I don't know what a good solution would be. :(

@oldman4U oldman4U marked this pull request as draft November 12, 2020 14:00
@AntoszHUN
Copy link
Contributor

Problems with the icon set? I could do it this weekend.

@oldman4U
Copy link
Contributor Author

Please check round miracle TFT35. There are some broken icons. Thank you

@AntoszHUN
Copy link
Contributor

Please check round miracle TFT35. There are some broken icons. Thank you

A round miracle? Broken icon? I do not understand.

@oldman4U
Copy link
Contributor Author

Screenshot 2020-11-15 at 07 51 27

This is the problem I see on 2 different machines and which I can not see using older themes.

@AntoszHUN
Copy link
Contributor

Screenshot 2020-11-15 at 07 51 27

This is the problem I see on 2 different machines and which I can not see using older themes.

I pass. I didn't do that. The 'Apply' icon is indicated by a 'check mark'. That's how I did it. Attached icon.
apply

@oldman4U
Copy link
Contributor Author

Your theme is ok. It is the round miracle theme which has the problem.

@AntoszHUN
Copy link
Contributor

Your theme is ok. It is the round miracle theme which has the problem.

But I didn't do it. : /

@oldman4U
Copy link
Contributor Author

oldman4U commented Nov 15, 2020 via email

@oldman4U
Copy link
Contributor Author

I am sorry, but I am lost. Will have to start from scratch.

Sorry

@oldman4U oldman4U closed this Nov 15, 2020
@AntoszHUN
Copy link
Contributor

It happens.

@oldman4U
Copy link
Contributor Author

New PR is done. Please check and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIGTREETECH TFT35 V2.0 BITMAPS MISSING ISSUE IN NON-UNIFIED UPDATE Folder upload
3 participants