Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SVGs have issues when you try and modify their contents because they have a different namespace that is only setup when you wrap them in a svg tag. So to allow internal SVG replacment I've found you can use wrapping in both template and svg tags which then works well with OOB swaps. It is also possible to do similar full swaps but you have to use hx-select and its not as easy.
Corresponding issue:
Testing
Performed manual testing of different oob internal svg swaps to check it works as expected
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded