Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of svg oob swaps #2882

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Sep 8, 2024

Description

SVGs have issues when you try and modify their contents because they have a different namespace that is only setup when you wrap them in a svg tag. So to allow internal SVG replacment I've found you can use wrapping in both template and svg tags which then works well with OOB swaps. It is also possible to do similar full swaps but you have to use hx-select and its not as easy.

Corresponding issue:

Testing

Performed manual testing of different oob internal svg swaps to check it works as expected

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Sep 8, 2024
@Telroshan
Copy link
Collaborator

(Note: took the liberty to fix a typo in the title and added some punctuation.)
Thanks !

@Telroshan Telroshan merged commit 230262c into bigskysoftware:master Sep 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants