Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Typescript to move configuration from const to let #2853

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Aug 27, 2024

Description

Upgrade of Typescript version to 5.5.4 to allow creation of d.ts file with let instead of const which seems to be the case with version 5.1 and above and this hopefully will allow typescript users to modify config items that were blocked from re-assignment with const.

tested with all recent releases of typescript and 5.5.4 have new type generation rules that seem to respect the jsdoc type annotations better. see Node Reuse in Declaration Emit in https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/

Also removed the duplicated src/htmx.d.ts file that is no longer used for the distribution? need to verify we no longer need to keep maintaining this file manually.

Resolved one type check for HttpVerb detected by updated typescript.

Corresponding issue:
#2850

Testing

Ran test suite and but I have not tested the generated d.ts file in a typescript project to confirm it resolves the original problem

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Aug 28, 2024
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Aug 28, 2024
@1cg 1cg merged commit 2ba7fd2 into bigskysoftware:dev Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants