Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra hx-swap-oob attribute that is not used in the page #2823

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Aug 16, 2024

Description

hx-swap-oob attribute is making its way onto the page/dom after ture/outerHTML oob swaps. They are not needed or used on the page and just add confusion so i've added two lines to remove them from the swapped in content during oobSwap()

Corresponding issue:
#2822

Testing

Wrote a couple of tests to make sure the tags were removed and found one test was broken by my change which I had to update. Also tested it on my test application to make sure the tags were not seen in the page after swaps.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@MichaelWest22 MichaelWest22 changed the base branch from master to dev August 16, 2024 03:02
@Telroshan Telroshan added enhancement New feature or request ready for review Issues that are ready to be considered for merging labels Aug 16, 2024
@1cg 1cg merged commit 0e1eeec into bigskysoftware:dev Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants