Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for mustache in client-side-templates extension. #2409

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

airblast-dev
Copy link
Contributor

@airblast-dev airblast-dev commented Mar 17, 2024

Description

The unnecessary escape sequences were removed from the mustache full example as they broke the output.
The template key "UserID" was renamed to "UserId" as the test API uses "UserId". The old key name would result in a blank string as the keys wouldnt match.

Corresponding issue:
#2407

Testing

I have tested the changed example in the docs. It is working correctly.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@airblast-dev
Copy link
Contributor Author

There is one more thing that should be fixed. The jsbin example linked right under the example in the docs is really out of date, and also uses the incorrect key name "UserID" instead of "UserId". It would be really sweet if the jsbin example could be updated by one of the maintainers with the new example, or just remove the jsbin example altogether.

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Mar 18, 2024
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants