Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: aria-selected true in Tabs HATEOS example #2404

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

nicoekkart
Copy link
Contributor

Description

The aria-selected attribute should be set to true in the first tab for consistency with the class selected being set.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

The `aria-selected` attribute should be set to true in the first tab for consistency with the class `selected` being set.
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Mar 17, 2024
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@alexpetros alexpetros merged commit af50cde into bigskysoftware:master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants