Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] clarify SSE hx-swap docs to note #784 #2327

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

cbiffle
Copy link
Contributor

@cbiffle cbiffle commented Feb 16, 2024

Description

The SSE extension docs suggest that hx-swap works, which it sort of does, except that (as noted in #784) the modifier functionality documented on the hx-swap attribute is silently ignored.

Corresponding issue: #784

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

(I'm not a node developer and don't have all the dependencies to run the test suite -- if you're concerned that this Markdown wording change might have broken the tests, lmk and I can look into it.)

Was pulling my hair out trying to get this working before I realized
that it's a known issue.
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Feb 25, 2024
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants