Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Hyperscript Tabs docs #2164

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

ocku
Copy link
Contributor

@ocku ocku commented Jan 8, 2024

Description

Fix typo in tabs-hyperscript by making the aria-controls property of the tabs (buttons) point to <div id="tab-contents" ...>

Corresponding issue:
#2163

Testing

(not applicable)

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@alexpetros
Copy link
Collaborator

We just recently removed the hyperscript from these examples, so you rebase this to fix the merge conflict, we can merge it.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocku
Copy link
Contributor Author

ocku commented Jan 13, 2024

👍 Well done. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls

Should www/content/examples/tabs-hateoas.md also be modified or not?

https://github.com/search?q=repo%3Abigskysoftware%2Fhtmx+%22tab-content%22

Thank you!

www/content/examples/tabs-hateoas.md appears to be working well, but I could change the IDs in this PR (tab-contents -> tab-content) to be consistent with the ones in that file.

Please let me know what would be the best course of action.

Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexpetros alexpetros merged commit 309593a into bigskysoftware:master Jan 13, 2024
@alexpetros
Copy link
Collaborator

www/content/examples/tabs-hateoas.md appears to be working well, but I could change the IDs in this PR (tab-contents -> tab-content) to be consistent with the ones in that file.

Not a big deal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants