-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in Hyperscript Tabs docs #2164
Conversation
We just recently removed the hyperscript from these examples, so you rebase this to fix the merge conflict, we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Well done. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls
Should www/content/examples/tabs-hateoas.md
also be modified or not?
https://github.com/search?q=repo%3Abigskysoftware%2Fhtmx+%22tab-content%22
Thank you!
Please let me know what would be the best course of action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Not a big deal :) |
Description
Fix typo in tabs-hyperscript by making the
aria-controls
property of the tabs (buttons) point to<div id="tab-contents" ...>
Corresponding issue:
#2163
Testing
(not applicable)
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded