Use faster regexp.test
over string.match
for testing against regex
#2053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As was mentioned by @xhaggi in this code review,
regexp.test
is faster thanstring.match
if the goal is to check if a string matches a regular expression.string.match
is only necessary if the goal is to extract a substring.Out of the six places in HTMX where
string.match
is used, four of them can be replaced byregexp.test
.Corresponding issue: None, suppose that's not necessary for this small change, but correct me if I'm wrong.
Testing
I ran the testing suite and everything came out green.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded