Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert readystate PR #2040

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Revert readystate PR #2040

merged 1 commit into from
Nov 30, 2023

Conversation

alexpetros
Copy link
Collaborator

Description

After discussion with @Telroshan, we're going to provide a new method that lets people initialize htmx at their own spot in the lifecycle if they load it in some nonstandard ways, rather than try to cover every possible gap in the loading cycle with closures. Discussion here: #2037 (comment)

Another PR for initialize to come.

Testing

Reverted to old tests.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@xhaggi
Copy link
Contributor

xhaggi commented Nov 28, 2023

Somehow everything returns #1485 😆

@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Nov 30, 2023
@1cg 1cg merged commit 40cd1a5 into master Nov 30, 2023
1 check passed
@1cg
Copy link
Contributor

1cg commented Nov 30, 2023

@xhaggi are you on the discord? I'd like to get you involved over there if not,

@alexpetros alexpetros deleted the revert-readystate-pr branch November 30, 2023 22:39
@xhaggi
Copy link
Contributor

xhaggi commented Dec 1, 2023

@1cg yes, mention me and I'll jump in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants