Add select option to htmx.ajax()
#1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpetros
changed the title
select option to htmx.ajax()
|
This looks terrific, thanks for dredging this out of that issue! Will give it a thorough read-through soon, but on first skim this is very well done. |
alexpetros
added
the
ready for review
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a PR for this issue #701 and saw that it was "add(ed) to a list" (comment). Hopefully this PR is helpful. Let me know if there are issues, I took some liberties in implementing it how I thought was best but I'm not sure if adding more properties to the
responseInfoobject is desirable. I added some tests and documentation.I thought the best API would be that the "HX-Reselect" header value should override the ajax api call but I wasn't sure. Let me know if that is incorrect.
Htmx is a great project thank you for working on it!