-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List extended selectors + caveats in hx-include doc #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good clarifications!
I wonder if copy-pasting that bit about the |
That's the next thing I was going to suggest! 😄 |
My only concern is that I think the |
I hadn't noticed this, indeed others use
var extendedSelectors = {
"closest": (elt, selector) => [closest(elt, normalizeSelector(selector.substr(8)))],
"find": (elt, selector) => [find(elt, normalizeSelector(selector.substr(5)))],
...
} (Using the short syntax on purpose here but ofc this isn't IE11 compatible) |
After letting this sit for too long, I've decided that just because we should do this eventually isn't a reason to hold up this PR. This is at least a step in the right direction. |
This addresses issue #1509
hx-include
supports the extended selectors, which were not mentioned in its documentationfind
for example, can be confusing when using an inherited hx-include attribute: added a note to explain that